For number type, use a user-defined validation text instead of "Please enter a valid value."#138
Open
Piskvor wants to merge 1 commit intonette:masterfrom
Open
For number type, use a user-defined validation text instead of "Please enter a valid value."#138Piskvor wants to merge 1 commit intonette:masterfrom
Piskvor wants to merge 1 commit intonette:masterfrom
Conversation
The JS library always uses a hardcoded error text if a type="number" field is misfilled. It should only fall back to the hardcoded text if no error message has been defined.
dg
force-pushed
the
master
branch
2 times, most recently
from
5f19501 to
105a1af
Compare
dg
force-pushed
the
master
branch
14 times, most recently
from
a6ec22a to
c2c4dc3
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
454e643 to
a8c2e65
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
571b36c to
841e5de
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
8ed13d7 to
d6aa86e
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
f1a8ed2 to
b10e0c0
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
94f43f0 to
fe374c5
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
cb844f0 to
1d8a434
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
479185b to
8da5796
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
a992748 to
0e1918f
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
8742d20 to
01f8ed8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JS library always uses a hardcoded error text: "Please enter a valid value." if a type="number" field is misfilled.
It should only fall back to the hardcoded text if no error message has been defined.